Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cve_rules folder name according to latest Yara-Rule repo structure #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sunilrebel
Copy link

to: @airbnb/binaryalert-maintainers
cc:
size: small|medium|large
resolves #

Background

Yara rules were not fetched from the defined folder because the repo structure changed and folder were renamed.

Changes

  • fixed the folder name according to current structure

Testing

Tested on my local system. Screenshot attached.

image

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.52% when pulling 8f2bbb0 on sunilrebel:master into a9c0f06 on airbnb:master.

@sunilrebel
Copy link
Author

What I have to do to increase the coverage? It is a folder name change which is used while cloning rules

@jdheyburn
Copy link

Any chance this can get merged? New builds of the project are missing out on these yara rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants