Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky ui-testing GitHub Actions workflow #348

Closed
wants to merge 7 commits into from

Conversation

mataku
Copy link
Contributor

@mataku mataku commented Aug 29, 2023

Context

In #342, I made testing GitHub Actions workflow work, which hadn't been working for some time. In the process of code review, I heard ui-testing workflow is unstable.

On my forked repo: https://github.com/mataku/Showkase, I tried to investigate with androidTest result reports but no particularly useful logs were displayed (like: #341 (comment))

I thought Android emulator itself may be unstable. After updating Android emulator, it seems to be stable. Tried with many retries: https://github.com/mataku/Showkase/actions/runs/5991426769

Changes

  • Update emulator build version
  • Upload AndroidTest report results regardless of whether the test was successful or unsuccessful to investigate easily
  • Regenerate screenshots in sample/screenshots/debug

@vinaygaba
Copy link
Collaborator

@mataku Thank you so much for investigating and helping with making the CI more reliable 🙏🏻

Do you know where the screenshot diffs on this PR are stemming from?

@mataku
Copy link
Contributor Author

mataku commented Aug 30, 2023

@vinaygaba
I don't know the details, but I replaced them after updating emulator because the test failed as it was.


Anyway, as you can see, this change is not enough because workflow results are still flaky. So I will look at it again when I have the time.

@mataku mataku closed this Aug 30, 2023
@mataku mataku deleted the feature/fix-flaky-test-workflow branch August 30, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants