Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix width incorrectly passed to showkaseHeightDp param in ShowkaseMetadata. #336

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Fix width incorrectly passed to showkaseHeightDp param in ShowkaseMetadata. #336

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a89d82
Fix `width` incorrectly passed to `showkaseHeightDp` param in `Showka…
julioromano Jul 7, 2023
aa0edac
Merge branch 'master' into patch-1
vinaygaba Aug 17, 2023
a1631eb
Merge branch 'master' into patch-1
vinaygaba Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-processor/src/main/java/com/airbnb/android/showkase/processor/models/ShowkaseMetadata.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ internal fun getShowkaseMetadataFromCustomAnnotation(
showkaseName = showkaseName,
showkaseGroup = showkaseGroup,
showkaseWidthDp = if (width == -1) null else width,
showkaseHeightDp = if (height == -1) null else width,
showkaseHeightDp = if (height == -1) null else height,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 Thank you for fixing it, typo indeed!

insideWrapperClass = commonMetadata.showkaseFunctionType == ShowkaseFunctionType.INSIDE_CLASS,
insideObject = commonMetadata.showkaseFunctionType.insideObject(),
element = element,
Expand Down
Loading