Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add padding for scope #331

Merged
merged 2 commits into from
Sep 20, 2024
Merged

add padding for scope #331

merged 2 commits into from
Sep 20, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Sep 20, 2024

Defines custom padding for a scope layout. The padding values are used by the ScopesPlugin to avoid node overlapping with the socket of the parent node.
Before, the conditions socket overlaps with task:

Screenshot from 2024-09-20 10-01-05

After:
Screenshot from 2024-09-20 09-56-02

Note: we need to update three places: 1) web app, 2) widget 3) HTML template. This is not good; we need to refactor the code in the future so that we create a library for all.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.62%. Comparing base (5937b88) to head (d190519).
Report is 79 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
+ Coverage   75.75%   80.62%   +4.87%     
==========================================
  Files          70       66       -4     
  Lines        4615     5147     +532     
==========================================
+ Hits         3496     4150     +654     
+ Misses       1119      997     -122     
Flag Coverage Δ
python-3.11 80.55% <ø> (+4.88%) ⬆️
python-3.12 80.55% <ø> (?)
python-3.9 80.58% <ø> (+4.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@agoscinski agoscinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good, just a bit doc missing.

Note: we need to update three places: 1) web app, 2) widget 3) HTML template. This is not good; we need to refactor the code in the future so that we create a library for all.

Can you make a note in some issue referencing this PR or open a new issue to just keep track of it?

docs/source/howto/html/if_task.html Show resolved Hide resolved
@superstar54
Copy link
Member Author

superstar54 commented Sep 20, 2024

Can you make a note in some issue referencing this PR or open a new issue to just keep track of it?

Yes, I created an issue

@superstar54 superstar54 merged commit 7d79bea into main Sep 20, 2024
8 checks passed
@superstar54 superstar54 deleted the fix/add_padding_for_scope branch September 20, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants