Update parser signature for aiida-shell v0.8, extend ShellJob docs, use prepare_shell_job_inputs
#326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeigerJ2
force-pushed
the
fix/316/custom-parser-signature
branch
from
286a9d4
to
7bb5264
Compare
superstar54
reviewed
Sep 20, 2024
GeigerJ2
force-pushed
the
fix/316/custom-parser-signature
branch
from
aadc826
to
ebe9cb9
Compare
GeigerJ2
changed the title
aiida-shell v0.8 and extend ShellJob docsaiida-shell v0.8, extend ShellJob docs, use prepare_shell_job_inputs
GeigerJ2
force-pushed
the
fix/316/custom-parser-signature
branch
3 times, most recently
from
0076c13
to
ccbb1c1
Compare
|
Finally, CI passing 😅 OK, this should be ready for review, @superstar54 :) |
GeigerJ2
force-pushed
the
fix/316/custom-parser-signature
branch
from
397f32d
to
f0f179f
Compare
GeigerJ2
force-pushed
the
fix/316/custom-parser-signature
branch
from
02656fd
to
13095ef
Compare
…ected input parameters.
|
Hi @GeigerJ2 , thanks for the work! I modified the |
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs some work, but already creating the PR now to see if CI runs through.