Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename package: aiida-testing -> aiida-test-cache #76

Merged
merged 7 commits into from
Nov 19, 2024
Merged

Rename package: aiida-testing -> aiida-test-cache #76

merged 7 commits into from
Nov 19, 2024

Conversation

danielhollas
Copy link
Collaborator

@danielhollas danielhollas commented Nov 18, 2024 •
edited
Loading

Fixes #60.

There are two things to discuss / bikeshed here:

  1. aiida-test-cache or aiida-testcache?
  2. Name of the default config file. I think we should definitely rename it to be consistent with the new name of the package, but do we also want to support the old name in a backwards compatible manner? My vote is no to keep the code simple, given that the number of current users is very low and I can simply make a PR to all of them.

Before merging this (or after?) I also need to:

  • Rename the repo
  • Change the configuration on ReadTheDocs appropriatelly

I also fixed the documentation build, see the new build for this PR https://aiida-testing--76.org.readthedocs.build/en/76/index.html

@danielhollas
Rename package: aiida-testing->aiida-test-cache
3586d7c 
The only remaining thing is the name of the default
config file, will be dealt with separately.
danielhollas
danielhollas commented Nov 18, 2024
View reviewed changes
pyproject.toml
@@ -51,7 +51,7 @@ dependencies = [

[project.optional-dependencies]
docs = ["sphinx", "sphinx-rtd-theme"]
testing = [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I was here, I made it in line with other AiiDA repos that use tests extras.

@danielhollas danielhollas requested a review from unkcpz November 19, 2024 00:53
unkcpz
unkcpz approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me.

@danielhollas
Copy link
Collaborator Author

@unkcpz thank you very much for review!

Renaming done, let's go! 🚀

@danielhollas danielhollas merged commit 463be41 into main Nov 19, 2024
17 checks passed
@danielhollas danielhollas deleted the name-change branch November 19, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unkcpz unkcpz unkcpz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consider name change
2 participants
@danielhollas @unkcpz