Reintroduce pull_request in GitHub workflow with if case
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The disadvantage of removing the `pull_request` as trigger event for an GitHub workflow is that it does not trigger for pushes from a foreign repo. To run the workflow also in this case without running the workflow twice for PRs based on the original repo we introduce an if case that runs the `pull_request` event only when it from a foreign repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran in PR #73 in the problem that the CI was not run, so I added this. I think aiida-core it does not show the pull_request events that are cancelled as in this PR, but I am not sure how it is done it there.
The disadvantage of removing the
pull_requestas trigger event for an GitHub workflow is that it does not trigger for pushes from a foreign repo. To run the workflow also in this case without running the workflow twice for PRs based on the original repo we introduce an if case that runs thepull_requestevent only when it from a foreign repo.See https://wildwolf.name/github-actions-how-to-avoid-running-the-same-workflow-multiple-times/ for more explanation