-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating to latest aiida: pydantic 2, graphene 3 #75
Conversation
Co-authored-by: Alexander Goscinski <[email protected]>
Co-authored-by: Alexander Goscinski <[email protected]>
Co-authored-by: Alexander Goscinski <[email protected]>
Co-authored-by: Alexander Goscinski <[email protected]>
Co-authored-by: Alexander Goscinski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through it with @eimrek. For some changes it is not very clear why they were needed, but it works and it follows FastAPI guidelines (specifically the async client). Also the create_upload_file
has to be adapted in the future to directly stream the byte string, but with that needs more work most likely on the aiida-core side. So it looks fine, merging it to make more progress on the endpoints!
Since we change the linter and formatter in the next PR we ignore failing pre-commit in the CI. RTD failure we fix in a future branch
In order to make this project work with AiiDA 2.5+, this pr migrates to
In the process of these migrations, the following things were changed:
Fixes #70