_dynamic_info_firecrest_version updated with new development

[khsrali]

/status/parameters endpoint of firecrest api is now updated with version value.
We fetch this way and drop the previous work around that was implemented.
Fixes:
#43

[codecov]

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.43%. Comparing base (133490a) to head (f848fdb).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
aiida_firecrest/transport.py	94.11%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   79.43%   82.43%   +2.99%     
==========================================
  Files           4        4              
  Lines         671      683      +12     
==========================================
+ Hits          533      563      +30     
+ Misses        138      120      -18     

Flag	Coverage Δ
pytests	82.43% <94.11%> (+2.99%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[agoscinski]

Are these comments still up do date with this PR?

I am a bit confused how the function _dynamic_info_firecrest_version works. You specify a version by the value, but if it is 0 then it tries to to retrieve the version dynamically. I guess that it is 0 and not None confuses me, but fine. Maybe can you add a bit doc to it because value is not such a meaningful name?

Why is the echo only done in case it is dynamically retrieved? Maybe you can add a comment there.

[khsrali]

Thanks a lot, @agoscinski for the review!

Are these comments still up do date with this PR?

yes, they are from the past, removed.

I am a bit confused how the function _dynamic_info_firecrest_version works. You specify a version by the value, but if it is 0 then it tries to to retrieve the version dynamically. I guess that it is 0 and not None confuses me, but fine. Maybe can you add a bit doc to it because value is not such a meaningful name?

Changed to None, doc added. Please check if it's clear. It's basically a click callback function.

Why is the echo only done in case it is dynamically retrieved? Maybe you can add a comment there.

Just to prevent verbosity. Usually when inputs are valid during setting up/configuring a computer in aiida, it remains quite.
I added echo for cases that it has to check something from the server. As a confirmation.

[agoscinski]

Looks clear to me, I just simplified the pytest a little bit, check out my commit

[khsrali]

Looks clear to me, I just simplified the pytest a little bit, check out my commit

Very good @agoscinski, thanks a lot!