Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two small fixes #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jdoumont
Copy link

Dear mberckx,

Peter Blaha shared your repository with me, as we had discussed the possibility of a docker container for Wien2k at some point. I tried to run your container and ran into two small issues:

  1. Something seemed to be wrong with the variable substitution in the makefile. I'm not a GNU make expert, but with the following changes it works for me.
  2. I suspect you use a Mac with Apple silicon, as the architecture of openblas was hardcoded to 'aarch64' in the siteconfig inputs. I changed it to $uname -m which should expand to the architecture of the system (x86_64 in my case). With this change, the setup should be portable.

I opened this PR as I thought you might be interested in these changes.

Best regards,
Jan Doumont

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant