Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postprocessing plugin #17

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Postprocessing plugin #17

merged 3 commits into from
Dec 20, 2023

Conversation

LucR31
Copy link
Collaborator

@LucR31 LucR31 commented Dec 20, 2023

No description provided.

@LucR31 LucR31 requested a review from yakutovicha December 20, 2023 14:50
yakutovicha
yakutovicha requested changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several small requests

aiida_flexpart/calculations/flexpart_post.py Outdated Show resolved Hide resolved
aiida_flexpart/parsers/flexpart_post.py Outdated Show resolved Hide resolved
aiida_flexpart/parsers/flexpart_post.py Outdated
return self.exit_codes.ERROR_MISSING_OUTPUT_FILES

# add output file
self.logger.info("Parsing '{}'".format(output_filename))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f-string, please

LucR31 and others added 2 commits December 20, 2023 15:53
yakutovicha
yakutovicha approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LucR31 LucR31 merged commit c0a732f into main Dec 20, 2023
0 of 6 checks passed
@LucR31 LucR31 deleted the new-plugin/post branch December 20, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakutovicha yakutovicha yakutovicha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucR31 @yakutovicha