Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deskew.cpp fill value assumes a 16-bit image #7

Open
brossetti opened this issue Jun 23, 2021 · 0 comments
Open

deskew.cpp fill value assumes a 16-bit image #7

brossetti opened this issue Jun 23, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@brossetti
Copy link
Contributor

The user-specified deskew fill value is given in the native image's intensity range. The fill value must therefore be scaled to work with the internal [0,1] double pixel type. Currently the scaling assumes that the native image intensity range is 16-bit. This should be templated to handle other bit depths.

kImageType::Pointer deskew_img = Deskew(img, angle, step, xy_res, (kPixelType) fill_value/std::numeric_limits<unsigned short>::max(), verbose); // TODO: scale fill_value by input type

@brossetti brossetti added the enhancement New feature or request label Jun 23, 2021
@brossetti brossetti changed the title deskew fill value assumes a 16-bit image deskew.cpp fill value assumes a 16-bit image Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant