Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix]fix kwargs in initializing ProblemData object #211

Closed
wants to merge 1 commit into from

Conversation

ShuN6211
Copy link
Contributor

@ShuN6211 ShuN6211 commented Sep 4, 2024

Description

Fix chunk that calls local search for CVRP.
At current project, calling CVRPEnv.local_search raises error. #212
This is because the names and type of kwargs
passed to ProblemData is wrong, and result in failing to instantiate ProblemData object.
Please check this lines!!
https://github.com/PyVRP/PyVRP/blob/9be2b6422230e4f3781b0d10388274cb1dda10db/pyvrp/_pyvrp.pyi#L155-L156

I tried to call local search for cvrp after applying the patch in this PR and it works.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@ShuN6211
Copy link
Contributor Author

ShuN6211 commented Sep 4, 2024

I will open an issue regarding this bug soon🙏

@ShuN6211
Copy link
Contributor Author

ShuN6211 commented Sep 4, 2024

#212 was closed, so this PR can be closed

@ShuN6211 ShuN6211 closed this Sep 4, 2024
@ShuN6211 ShuN6211 deleted the hotfix-cvrp-local-search branch September 4, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant