Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #33: Change yaml linting line length to 120 #34

Conversation

SonOfLope
Copy link
Contributor

  • Adding config file for yamllint with rule for line length set to 120
  • Fix all yaml violations

Copy link
Member

@ThomasCardin ThomasCardin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be quite a bit more changes than just changing the line length to 120.

@SonOfLope
Copy link
Contributor Author

There seems to be quite a bit more changes than just changing the line length to 120.

We are resolving all yaml violations that we didnt resolved until we changed the linee length ruling

@SonOfLope SonOfLope merged commit 9a33843 into main Feb 12, 2024
4 checks passed
SonOfLope added a commit that referenced this pull request Feb 12, 2024
SonOfLope added a commit that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a developer, I would like to change line length rules for yaml files to 120
3 participants