-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #28: As a DevOps, I would like to automate Azure infrastructure deployment using Terraform #29
Conversation
…e Pipelines [skip ci]
…ginx' into 28-as-a-devops-i-would-like-to-automate-azure-infrastructure-deployment-using-terraform
Set in draft to discuss about trigger steps for this workflow |
do we want to add https://github.com/ai-cfia/github-workflows/blob/main/.github/workflows/workflow-yaml-check.md and a terraform linter? |
Added with ai-cfia/github-workflows#88 |
…fig file and add tf required version
I also added an approval process for terraform apply step. It waits for an approval on Azure Devops AI-Lab repository (where we got access to the Azure service connector and where the Azure pipeline terraform-apply.yml is being applied from). Once one of the listed approvers (Thomas or me) accepts the Terraform plan, the job to apply the plan gets executed. Once I document this process I will set the PR ready for review |
Documentation added to our internal wiki. |
… to prove working pipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved minus the missing newline EOF (which should have been caught by a github workflow)
I dont think we lint hcl files in our workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like jonathan said, we don't lint .hcl file, maybe we could use https://github.com/super-linter/super-linter. I'll write an issue about it.
...this is part of the generic standards validation workflow that should apply to ALL files: I see it seems to be running, so is this broken or misconfigured? |
This pull request introduces the necessary configurations on the testing repository from our Azure Devops Repository AI-LAB to establish an integration between our Azure infrastructure and our source control management on GitHub. By using an Azure Service Principal and a GitHub service connector previously configured on our Azure Devops, we are able to execute Terraform workflows within the Azure DevOps AI-LAB repository while using this repository (infra) as source code for the workflows.
I suggest we use this solution as of now to migrate our services to GCP to Azure while I open a ticket with the Cloud team to provide a new service principal providing permissions to this repository (infra) to execute directly to our Azure subscription without the use of the middle-man (AI-LAB repository).
The following code simply creates a ressource group as an example to prove that the workflow works :
This allows us to move on to the next step of migrating our services to our Azure subscription.
TODO