-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final Capstone- Code Buddy V1 #18
base: main
Are you sure you want to change the base?
Conversation
Project setup
Code Buddy - Header
Work on User UI/Redux and other Redux Stores
Finalize UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good job so far!
There are only some very small issues that you still need to work on to prepare your project for the final evaluation but you are almost there!
Suggested changes
Check the comments under the review.
You can also connsider:
- Write tests for your application, as they are very important.
You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better.
Highlights
- Awesome README file and PR description.
- Your code is clean and well organized.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
work correctly both with client-side routing and a non-root public URL. | ||
Learn how to configure a non-root public URL by running `npm run build`. | ||
--> | ||
<title>React Redux App</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- (OPTIONAL) It would be awesome if you put a personalized title and icon in your app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for letting us know. We did it!
import baseURL from '../app/api'; | ||
|
||
const endPointUser = `${baseURL}/users`; | ||
// const endPointUserDetails = `${endPointUser}/user_details`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Don't forget to delete this if you're not using it.
import FavoriteOutlinedIcon from '@mui/icons-material/FavoriteOutlined'; | ||
import GroupsOutlinedIcon from '@mui/icons-material/GroupsOutlined'; | ||
import EventNoteOutlinedIcon from '@mui/icons-material/EventNoteOutlined'; | ||
// import EventAvailableIcon from '@mui/icons-material/EventAvailable'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Don't forget to delete this if you're not using it.
}, [status]); | ||
|
||
const handleOnClickReserve = () => { | ||
console.log(meeting); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Don't forget to delete this if you're not using it.
We opened this PR for you to review our project if it is as requested ποΈ
Here we created a React app as we used it for our Code Buddy App frontend. π― π―
Project requirements that are done:
Feel free to review π our project and if you have any questions please ask us! πͺ
Frontend pull