Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Capstone- Code Buddy V1 #18

Open
wants to merge 90 commits into
base: main
Choose a base branch
from
Open

Final Capstone- Code Buddy V1 #18

wants to merge 90 commits into from

Conversation

ahzia
Copy link
Owner

@ahzia ahzia commented Feb 5, 2022

We opened this PR for you to review our project if it is as requested πŸ‘οΈ

Here we created a React app as we used it for our Code Buddy App frontend. πŸ’― πŸ’―

Project requirements that are done:

  • Set up of the project βœ…
  • Create website header and make actions responsive βœ…
  • Create UI structure for User βœ…
  • Create UI structure for Meetings βœ…
  • Create UI structure for Reservations βœ…
  • Setup Redux βœ…

Feel free to review πŸ‘€ our project and if you have any questions please ask us! πŸ’ͺ

Frontend pull

Copy link

@MuriloRoque MuriloRoque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Donard97, @ahzia,

Very good job so far!
There are only some very small issues that you still need to work on to prepare your project for the final evaluation but you are almost there!

Suggested changes

Check the comments under the review.

You can also connsider:

  • Write tests for your application, as they are very important.

You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better.

Highlights

  • Awesome README file and PR description.
  • Your code is clean and well organized.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

work correctly both with client-side routing and a non-root public URL.
Learn how to configure a non-root public URL by running `npm run build`.
-->
<title>React Redux App</title>
Copy link

@MuriloRoque MuriloRoque Feb 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • (OPTIONAL) It would be awesome if you put a personalized title and icon in your app.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for letting us know. We did it!

import baseURL from '../app/api';

const endPointUser = `${baseURL}/users`;
// const endPointUserDetails = `${endPointUser}/user_details`;
Copy link

@MuriloRoque MuriloRoque Feb 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Don't forget to delete this if you're not using it.

import FavoriteOutlinedIcon from '@mui/icons-material/FavoriteOutlined';
import GroupsOutlinedIcon from '@mui/icons-material/GroupsOutlined';
import EventNoteOutlinedIcon from '@mui/icons-material/EventNoteOutlined';
// import EventAvailableIcon from '@mui/icons-material/EventAvailable';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Don't forget to delete this if you're not using it.

}, [status]);

const handleOnClickReserve = () => {
console.log(meeting);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Don't forget to delete this if you're not using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants