-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CoSTAR Dataset Joints vector embeddings #21
base: master
Are you sure you want to change the base?
CoSTAR Dataset Joints vector embeddings #21
Conversation
…als between 2 frames
…orithms? not clear of code state
…rameter grid search path strings
* multi_channel_search: cnn/model_search.py doc genotype _parse(weights) fn cnn/genotypes.py add max_w training run commands cnn/genotypes.py add model flops cnn/genotypes.py SHARP_DARTS_MAX_W order 1 search genotype genotypes.py add SharpSepConvDARTS max_w train_search.py multi_channel if statement # Conflicts: # cnn/genotypes.py
…y across computers.
…ARTS. Also added hacked and unhacked versions of sharper search space.
* 'sharper' of github.com:ahundt/sharpDARTS: genotypes.py update sharper no hacks run command train.py add SHARPER_PRIMITIVES option to help
* sharper_docs: README.md explain how to generate cosine power annealing charts. README.md typo fix README.md clarify steps for model search. README.md caps fix README.md add svg images of cos power annealing README.md typo fixes README.md add images README.md updated with new details cnn/visualize.py improve viz to make sense dataset.py reference source for some lines in this file LICENSE copyright update README.md explain cosine power annealing README.md add differentiable hyperparameter search README.md ack-grep command README.md first sharpDARTS readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow this code looks pretty clean overall, thanks!
-
Could you merge the changes from the branch called sharper, and then add instructions to run training and embedding visualization to the
README.md
?- I'll need the command line-by-line instructions I can copy paste in myself to create the embeddings myself and visualize them.
-
Were you able to train any new embeddings with these? Did it work ok? Could you create a screenshot and add it to the README.md to show what is expected?
-
Is there also a specific version of the costar_dataset repository I'll need?
Am I correct that this code goes with ahundt/costar_dataset#9? |
Yes, now you would need the latest version of the costar dataset from the feature_embeddings branch - 4cd22cb. |
I also merged it with the sharper branch. |
Edit: Sorry the comments here were for the wrong pull request. I'm testing this PR now. |
I tried running the commands as specified in your README.md changes and it crashed right away:
I'm guessing that's in the following lines of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This currently seems to crash right away when I follow the instructions, see notes above and below.
Package [graphviz](https://graphviz.readthedocs.io/en/stable/index.html) is required to visualize the learned cells | ||
``` | ||
python visualize.py DARTS | ||
``` | ||
where `DARTS` can be replaced by any customized architectures in `genotypes.py`. | ||
|
||
## Citation | ||
If you use any part of this code in your research, please cite our [paper](https://arxiv.org/abs/1806.09055): | ||
## Training Temporal Distance Classifier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All of your additions look like they are under the original DARTS readme section, not in a separate section or below sharpDARTS. We need to create a separate section before the DARTS section for your new changes. The DARTS section begins at "The sharpDARTS Repository is Based on Differentiable Architecture Search (DARTS)"
- Notes here must link to the original paper and to the costar dataset, explain what this part of the code is/does so people can figure out what a "Temporal Distance Classifier" etc is.
No description provided.