Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoSTAR Dataset Joints vector embeddings #21

Open
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

priyankahubli
Copy link
Collaborator

No description provided.

ahundt and others added 30 commits March 22, 2019 02:53
* multi_channel_search:
  cnn/model_search.py doc genotype _parse(weights) fn
  cnn/genotypes.py add max_w training run commands
  cnn/genotypes.py add model flops
  cnn/genotypes.py SHARP_DARTS_MAX_W order 1 search genotype
  genotypes.py add SharpSepConvDARTS max_w
  train_search.py multi_channel if statement

# Conflicts:
#	cnn/genotypes.py
…ARTS.

Also added hacked and unhacked versions of sharper search space.
* 'sharper' of github.com:ahundt/sharpDARTS:
  genotypes.py update sharper no hacks run command
  train.py add SHARPER_PRIMITIVES option to help
ahundt and others added 11 commits May 30, 2019 16:47
* sharper_docs:
  README.md explain how to generate cosine power annealing charts.
  README.md typo fix
  README.md clarify steps for model search.
  README.md caps fix
  README.md add svg images of cos power annealing
  README.md typo fixes
  README.md add images
  README.md updated with new details
  cnn/visualize.py improve viz to make sense
  dataset.py reference source for some lines in this file
  LICENSE copyright update
  README.md explain cosine power annealing
  README.md add differentiable hyperparameter search
  README.md ack-grep command
  README.md first sharpDARTS readme
Copy link
Owner

@ahundt ahundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this code looks pretty clean overall, thanks!

  • Could you merge the changes from the branch called sharper, and then add instructions to run training and embedding visualization to the README.md?

    • I'll need the command line-by-line instructions I can copy paste in myself to create the embeddings myself and visualize them.
  • Were you able to train any new embeddings with these? Did it work ok? Could you create a screenshot and add it to the README.md to show what is expected?

  • Is there also a specific version of the costar_dataset repository I'll need?

cnn/train_costar.py Outdated Show resolved Hide resolved
cnn/model.py Outdated Show resolved Hide resolved
@ahundt
Copy link
Owner

ahundt commented Jun 9, 2019

Am I correct that this code goes with ahundt/costar_dataset#9?

@priyankahubli
Copy link
Collaborator Author

Yes, now you would need the latest version of the costar dataset from the feature_embeddings branch - 4cd22cb.
I have added and made the changes you requested. Please let me know if this is okay.
Thanks!

@priyankahubli
Copy link
Collaborator Author

I also merged it with the sharper branch.

@ahundt
Copy link
Owner

ahundt commented Jul 12, 2019

Edit: Sorry the comments here were for the wrong pull request. I'm testing this PR now.

@ahundt ahundt changed the title Joints vector embeddings CoSTAR Dataset Joints vector embeddings Jul 12, 2019
@ahundt
Copy link
Owner

ahundt commented Jul 12, 2019

I tried running the commands as specified in your README.md changes and it crashed right away:

ahundt@femur|~/src/darts/cnn on priyanka_hard_youtube?
± export CUDA_VISIBLE_DEVICES="1" && python3 train_costar.py --data ~/.keras/datasets/costar_block_stacking_dataset_v0.4 --arch TDC --epochs 200 --batch_size 128 --feature_mode time_difference_images --num_images_per_example 200
Warning:  apex was installed without --cuda_ext. Fused syncbn kernels will be unavailable.  Python fallbacks will be used instead.
Warning:  apex was installed without --cuda_ext.  FusedAdam will be unavailable.
Warning:  apex was installed without --cuda_ext.  FusedLayerNorm will be unavailable.
/usr/local/lib/python3.5/dist-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.
  from ._conv import register_converters as _register_converters
Tensorflow is not installed. Skipping tf related imports
Experiment dir : eval-20190712-164157-EXP-stacking-TDC-0
2019_07_12_16_41_57 loading op dict: operations.OPS
2019_07_12_16_41_57 loading primitives:genotypes.PRIMITIVES
2019_07_12_16_41_57 primitives: ['none', 'max_pool_3x3', 'skip_connect', 'sep_conv_3x3', 'dil_conv_3x3', 'flood_conv_3x3', 'dil_flood_conv_3x3', 'choke_conv_3x3', 'dil_choke_conv_3x3']
Getting stacking data
Using CoSTAR Dataset
2019_07_12_16_41_59 Initial Learning Rate: 0.004690909090909092                                                                                                                                                                                                                            
Traceback (most recent call last):                                                                                                                                                                                                                                                         
  File "train_costar.py", line 796, in <module>
    main()
  File "train_costar.py", line 366, in main
    train_stats = train(train_loader, model, criterion, optimizer, int(epoch), args)
  File "train_costar.py", line 500, in train
    prefetcher = data_prefetcher(train_loader, cutout=args.cutout, cutout_length=args.cutout_length)
  File "train_costar.py", line 459, in __init__
    self.preload()
  File "train_costar.py", line 463, in preload
    self.next_input_img, self.next_input_vec, self.next_target = next(self.loader)
ValueError: not enough values to unpack (expected 3, got 2)
-> [1]

I'm guessing that's in the following lines of train_costar.py?


    prefetcher = data_prefetcher(train_loader, cutout=args.cutout, cutout_length=args.cutout_length)

    cart_error, angle_error = [], []
    input_img, input_vec, target = prefetcher.next()

Copy link
Owner

@ahundt ahundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currently seems to crash right away when I follow the instructions, see notes above and below.

Package [graphviz](https://graphviz.readthedocs.io/en/stable/index.html) is required to visualize the learned cells
```
python visualize.py DARTS
```
where `DARTS` can be replaced by any customized architectures in `genotypes.py`.

## Citation
If you use any part of this code in your research, please cite our [paper](https://arxiv.org/abs/1806.09055):
## Training Temporal Distance Classifier
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. All of your additions look like they are under the original DARTS readme section, not in a separate section or below sharpDARTS. We need to create a separate section before the DARTS section for your new changes. The DARTS section begins at "The sharpDARTS Repository is Based on Differentiable Architecture Search (DARTS)"
  2. Notes here must link to the original paper and to the costar dataset, explain what this part of the code is/does so people can figure out what a "Temporal Distance Classifier" etc is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants