Grpc gateway 2.7.0 #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: 1. Replace github.com/grpc-ecosystem/grpc-gateway with github.com/grpc-ecosystem/grpc-gateway/v2 in all golang source files and in scripts/genproto.sh. 2. The only exception is to manually replace github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger with github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2. Signed-off-by: Benjamin Wang <[email protected]>
Firstly run the following commands under `api` and `tools/mod` directories respectively: 1. go get github.com/grpc-ecosystem/grpc-gateway/[email protected] 2. go mod tidy Secondly run command below, ./scripts/fix.sh Signed-off-by: Benjamin Wang <[email protected]>
ahrtr
force-pushed
the
grpc_gateway_2.7.0
branch
3 times, most recently
from
442f06f to
a8a8ae5
Compare
The third_party/googleapis has been removed from github.com/grpc-ecosystem/grpc-gateway/v2, and the solution for now is to get them included in etcd repo directly. Please refer to grpc-ecosystem/grpc-gateway#1065 (comment) In the future, we may consider to manage the protobuf dependencies using https://github.com/bufbuild/buf. Please see grpc-ecosystem/grpc-gateway#1065 (comment). Signed-off-by: Benjamin Wang <[email protected]>
ahrtr
force-pushed
the
grpc_gateway_2.7.0
branch
2 times, most recently
from
9ce5bb7 to
9a1c1ba
Compare
…o on command line
The value of `go_package` in google/protobuf/descriptor.proto is "descriptor",
which isn't supported by protoc-gen-grpc-gateway v2. The error message is:
```
stderr: protoc-gen-grpc-gateway: invalid Go import path "descriptor" for "google/protobuf/descriptor.proto"
stderr:
stderr: The import path must contain at least one period ('.') or forward slash ('/') character.
```
The solution is to specify the go import path on command line in format: M${PROTO_FILE}=${GO_IMPORT_PATH}.
Signed-off-by: Benjamin Wang <[email protected]>
ahrtr
force-pushed
the
grpc_gateway_2.7.0
branch
from
9a1c1ba to
57b0060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.