Skip to content

Commit

Permalink
Merge pull request r0adkll#85 from hamz4k/bump_default_build_tools_ve…
Browse files Browse the repository at this point in the history
…rsion

update default build-tools version from 29.0.3 to 33.0.0
  • Loading branch information
r0adkll authored Feb 29, 2024
2 parents 349ebde + 6b21a12 commit f30bdd3
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Then copy the contents of the `.txt` file to your GH secrets

## ENV: `BUILD_TOOLS_VERSION`

**Optional:** You can manually specify a version of build-tools to use. We use `29.0.3` by default.
**Optional:** You can manually specify a version of build-tools to use. We use `34.0.0` by default.

## Outputs

Expand Down Expand Up @@ -68,8 +68,8 @@ steps:
keyStorePassword: ${{ secrets.KEY_STORE_PASSWORD }}
keyPassword: ${{ secrets.KEY_PASSWORD }}
env:
# override default build-tools version (29.0.3) -- optional
BUILD_TOOLS_VERSION: "30.0.2"
# override default build-tools version (33.0.0) -- optional
BUILD_TOOLS_VERSION: "34.0.0"

# Example use of `signedReleaseFile` output -- not needed
- uses: actions/upload-artifact@v2
Expand Down
2 changes: 1 addition & 1 deletion lib/signing.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function signApkFile(apkFile, signingKeyFile, alias, keyStorePassword, keyPasswo
return __awaiter(this, void 0, void 0, function* () {
core.debug("Zipaligning APK file");
// Find zipalign executable
const buildToolsVersion = process.env.BUILD_TOOLS_VERSION || '29.0.3';
const buildToolsVersion = process.env.BUILD_TOOLS_VERSION || '33.0.0';
const androidHome = process.env.ANDROID_HOME;
const buildTools = path.join(androidHome, `build-tools/${buildToolsVersion}`);
if (!fs.existsSync(buildTools)) {
Expand Down
2 changes: 1 addition & 1 deletion src/signing.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export async function signApkFile(
core.debug("Zipaligning APK file");

// Find zipalign executable
const buildToolsVersion = process.env.BUILD_TOOLS_VERSION || '29.0.3';
const buildToolsVersion = process.env.BUILD_TOOLS_VERSION || '33.0.0';
const androidHome = process.env.ANDROID_HOME;
const buildTools = path.join(androidHome!, `build-tools/${buildToolsVersion}`);
if (!fs.existsSync(buildTools)) {
Expand Down

0 comments on commit f30bdd3

Please sign in to comment.