Skip to content

Commit

Permalink
Open HistoryStorageOverview in center panel from HistoryPanel
Browse files Browse the repository at this point in the history
Previously, if we clicked the History storage button for the current
history in the `HistoryPanel`, it took over the whole screen because
the `StorageDashboardRoutes` are not children of the `Analysis`
route.

Changed it so the `HistoryStorageOverview` route opens in the
center panel as an `Analysis` route (only from the `HistoryPanel`,
otherwise, it is still opened as one of the `StorageDashboardRoutes`)

Fixes galaxyproject#17026
  • Loading branch information
ahmedhamidawan committed Nov 17, 2023
1 parent 19b0ffd commit e5ce95d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ onMounted(() => {
});
function onDashboard() {
router.push({ name: "HistoryOverview", params: { historyId: props.history.id } });
router.push({ name: "HistoryOverviewInAnalysis", params: { historyId: props.history.id } });
}
function setFilter(filter: string) {
Expand Down
7 changes: 7 additions & 0 deletions client/src/entry/analysis/router.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ import HistoryArchive from "@/components/History/Archiving/HistoryArchive.vue";
import HistoryArchiveWizard from "@/components/History/Archiving/HistoryArchiveWizard.vue";
import NotificationsList from "@/components/Notifications/NotificationsList.vue";
import Sharing from "@/components/Sharing/SharingPage.vue";
import HistoryStorageOverview from "@/components/User/DiskUsage/Visualizations/HistoryStorageOverview.vue";
import WorkflowPublished from "@/components/Workflow/Published/WorkflowPublished.vue";

Vue.use(VueRouter);
Expand Down Expand Up @@ -366,6 +367,12 @@ export function getRouter(Galaxy) {
published: route.params.actionId == "list_published" ? true : false,
}),
},
{
path: "storage/history/:historyId",
name: "HistoryOverviewInAnalysis",
component: HistoryStorageOverview,
props: true,
},
{
path: "tours",
component: TourList,
Expand Down

0 comments on commit e5ce95d

Please sign in to comment.