Skip to content

Commit

Permalink
Mark tool_id required in is_missing_shed_tool method
Browse files Browse the repository at this point in the history
  • Loading branch information
mvdbeek committed Feb 1, 2024
1 parent b757281 commit d092e02
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions lib/galaxy/tool_util/toolbox/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -761,11 +761,8 @@ def get_tool(self, tool_id, tool_version=None, get_all_versions=False, exact=Fal
def has_tool(self, tool_id: str, tool_version: Optional[str] = None, exact: bool = False):
return self.get_tool(tool_id, tool_version=tool_version, exact=exact) is not None

def is_missing_shed_tool(self, tool_id: Optional[str]) -> bool:
def is_missing_shed_tool(self, tool_id: str) -> bool:
"""Confirm that the tool ID does reference a shed tool and is not installed."""
if tool_id is None:
# This is not a tool ID.
return False
if "repos" not in tool_id:
# This is not a shed tool.
return False
Expand Down

0 comments on commit d092e02

Please sign in to comment.