Skip to content

Commit

Permalink
do not require annotation for wfs, fix comments and user facing msgs
Browse files Browse the repository at this point in the history
  • Loading branch information
ahmedhamidawan committed Oct 31, 2023
1 parent 2ff15b8 commit cc34734
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion client/src/components/Workflow/Editor/Attributes.vue
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
<b-textarea
id="workflow-annotation"
v-model="annotationCurrent"
:state="!annotationCurrent ? false : null"
@keyup="$emit('update:annotationCurrent', annotationCurrent)" />
<div class="form-text text-muted">These notes will be visible when this workflow is viewed.</div>
</div>
Expand Down
6 changes: 3 additions & 3 deletions client/src/components/Workflow/Editor/Index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -565,9 +565,9 @@ export default {
this.onUpdateStep(step);
},
async onCreate() {
if (!this.name || !this.annotation) {
const response = "Must provide name and annotation before creation...";
this.onWorkflowError("Creating workflow failed...", response, {
if (!this.name) {
const response = "Please provide a name for your workflow.";
this.onWorkflowError("Creating workflow failed", response, {
Ok: () => {
this.hideModal();
},
Expand Down
2 changes: 1 addition & 1 deletion lib/galaxy/webapps/galaxy/controllers/workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ def editor(self, trans, id=None, workflow_id=None, version=None, **kwargs):
"workflows": workflows,
}

# if existing workflow, add add its data to the model
# for existing workflow add add its data to the model
if new_workflow is False:
editor_config.update(
{
Expand Down

0 comments on commit cc34734

Please sign in to comment.