fix prop provided to wrong component, removing redundant loading span

Co-authored-by: David López <[email protected]>
ahmedhamidawan · Dec 10, 2024 · 67f47bf · 67f47bf
1 parent 4532464
commit 67f47bf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/client/src/components/WorkflowInvocationState/WorkflowInvocationMetrics.vue b/client/src/components/WorkflowInvocationState/WorkflowInvocationMetrics.vue
@@ -15,7 +15,7 @@ const VegaWrapper = () => import("./VegaWrapper.vue");
 
 interface Props {
     invocationId: string;
-    terminal?: boolean;
+    notTerminal?: boolean;
 }
 const props = defineProps<Props>();
 
@@ -384,7 +384,7 @@ const groupByInTitles = computed(() => {
 
 <template>
     <div>
-        <BAlert v-if="!props.terminal" variant="warning" show>
+        <BAlert v-if="props.notTerminal" variant="warning" show>
             <LoadingSpan message="Metrics will update and change as the workflow progresses." />
         </BAlert>
         <BContainer>

diff --git a/client/src/components/WorkflowInvocationState/WorkflowInvocationState.vue b/client/src/components/WorkflowInvocationState/WorkflowInvocationState.vue
@@ -360,16 +360,11 @@ async function onCancel() {
                     </BBadge>
                 </template>
                 <div v-if="invocationAndJobTerminal">
-                    <WorkflowInvocationExportOptions
-                        :invocation-id="invocation.id"
-                        :terminal="invocationAndJobTerminal" />
+                    <WorkflowInvocationExportOptions :invocation-id="invocation.id" />
                 </div>
-                <BAlert v-else variant="info" show>
-                    <LoadingSpan message="Waiting to complete invocation" />
-                </BAlert>
             </BTab>
             <BTab title="Metrics" :lazy="true">
-                <WorkflowInvocationMetrics :invocation-id="invocation.id"></WorkflowInvocationMetrics>
+                <WorkflowInvocationMetrics :invocation-id="invocation.id" :not-terminal="!invocationAndJobTerminal" />
             </BTab>
             <template v-slot:tabs-end>
                 <BButton