Skip to content

Commit

Permalink
Merge pull request galaxyproject#17433 from davelopez/23.1_fix_bulk_o…
Browse files Browse the repository at this point in the history 
…perations_menu

[23.1] Fix history bulk operations menu conditions
  • Loading branch information
@mvdbeek
mvdbeek authored Feb 8, 2024
2 parents cb97ef1 + f60f0ae commit 62ee88d
Show file tree
Hide file tree
Showing 3 changed files with 59 additions and 7 deletions.
47 changes: 44 additions & 3 deletions client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -82,28 +82,41 @@ describe("History Selection Operations", () => {
expect(wrapper.find(option).exists()).toBe(false);
});

it("should display 'unhide' option only on hidden items", async () => {
it("should display 'unhide' option on hidden items", async () => {
const option = '[data-description="unhide option"]';
expect(wrapper.find(option).exists()).toBe(false);
await wrapper.setProps({ filterText: "visible:false" });
expect(wrapper.find(option).exists()).toBe(true);
});

it("should display 'delete' option only on non-deleted items", async () => {
it("should display 'unhide' option when hidden and visible items are mixed", async () => {
const option = '[data-description="unhide option"]';
expect(wrapper.find(option).exists()).toBe(false);
await wrapper.setProps({ filterText: "visible:any" });
expect(wrapper.find(option).exists()).toBe(true);
});

it("should display 'delete' option on non-deleted items", async () => {
const option = '[data-description="delete option"]';
expect(wrapper.find(option).exists()).toBe(true);
await wrapper.setProps({ filterText: "deleted:true" });
expect(wrapper.find(option).exists()).toBe(false);
});

it("should display 'delete' option when non-deleted and deleted items are mixed", async () => {
const option = '[data-description="delete option"]';
await wrapper.setProps({ filterText: "deleted:any" });
expect(wrapper.find(option).exists()).toBe(true);
});

it("should display 'permanently delete' option always", async () => {
const option = '[data-description="purge option"]';
expect(wrapper.find(option).exists()).toBe(true);
await wrapper.setProps({ filterText: "deleted:true" });
expect(wrapper.find(option).exists()).toBe(true);
});

it("should display 'undelete' option only on deleted and non-purged items", async () => {
it("should display 'undelete' option on deleted and non-purged items", async () => {
const option = '[data-description="undelete option"]';
expect(wrapper.find(option).exists()).toBe(false);
await wrapper.setProps({
Expand All @@ -113,6 +126,15 @@ describe("History Selection Operations", () => {
expect(wrapper.find(option).exists()).toBe(true);
});

it("should display 'undelete' option when non-purged items (deleted or not) are mixed", async () => {
const option = '[data-description="undelete option"]';
await wrapper.setProps({
filterText: "deleted:any",
contentSelection: getNonPurgedContentSelection(),
});
expect(wrapper.find(option).exists()).toBe(true);
});

it("should not display 'undelete' when is manual selection mode and all selected items are purged", async () => {
const option = '[data-description="undelete option"]';
await wrapper.setProps({
Expand All @@ -134,6 +156,17 @@ describe("History Selection Operations", () => {
expect(wrapper.find(option).exists()).toBe(true);
});

it("should display 'undelete' option when is query selection mode and filtering by any deleted state", async () => {
const option = '[data-description="undelete option"]';
// In query selection mode we don't know if some items may not be purged, so we allow to undelete
await wrapper.setProps({
filterText: "deleted:any",
contentSelection: getPurgedContentSelection(),
isQuerySelection: true,
});
expect(wrapper.find(option).exists()).toBe(true);
});

it("should display collection building options only on visible and non-deleted items", async () => {
const buildListOption = '[data-description="build list"]';
const buildPairOption = '[data-description="build pair"]';
Expand All @@ -149,6 +182,14 @@ describe("History Selection Operations", () => {
expect(wrapper.find(buildListOption).exists()).toBe(false);
expect(wrapper.find(buildPairOption).exists()).toBe(false);
expect(wrapper.find(buildListOfPairsOption).exists()).toBe(false);
await wrapper.setProps({ filterText: "visible:any" });
expect(wrapper.find(buildListOption).exists()).toBe(false);
expect(wrapper.find(buildPairOption).exists()).toBe(false);
expect(wrapper.find(buildListOfPairsOption).exists()).toBe(false);
await wrapper.setProps({ filterText: "deleted:any" });
expect(wrapper.find(buildListOption).exists()).toBe(false);
expect(wrapper.find(buildPairOption).exists()).toBe(false);
expect(wrapper.find(buildListOfPairsOption).exists()).toBe(false);
});

it("should display list building option when all are selected", async () => {
Expand Down
11 changes: 9 additions & 2 deletions client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.vue
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@
data-description="undelete option">
<span v-localize>Undelete</span>
</b-dropdown-item>
<b-dropdown-item v-if="!showDeleted" v-b-modal:delete-selected-content data-description="delete option">
<b-dropdown-item
v-if="!showStrictDeleted"
v-b-modal:delete-selected-content
data-description="delete option">
<span v-localize>Delete</span>
</b-dropdown-item>
<b-dropdown-item v-b-modal:purge-selected-content data-description="purge option">
Expand Down Expand Up @@ -193,10 +196,14 @@ export default {
computed: {
/** @returns {Boolean} */
showHidden() {
return HistoryFilters.checkFilter(this.filterText, "visible", false);
return !HistoryFilters.checkFilter(this.filterText, "visible", true);
},
/** @returns {Boolean} */
showDeleted() {
return !HistoryFilters.checkFilter(this.filterText, "deleted", false);
},
/** @returns {Boolean} */
showStrictDeleted() {
return HistoryFilters.checkFilter(this.filterText, "deleted", true);
},
/** @returns {Boolean} */
Expand Down
8 changes: 6 additions & 2 deletions lib/galaxy/webapps/galaxy/services/history_contents.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1417,8 +1417,12 @@ def _unhide(self, item: HistoryItemModel):

def _delete(self, item: HistoryItemModel, trans: ProvidesHistoryContext):
if isinstance(item, HistoryDatasetCollectionAssociation):
return self.dataset_collection_manager.delete(trans, "history", item.id, recursive=True, purge=False)
return self.hda_manager.delete(item, flush=self.flush)
self.dataset_collection_manager.delete(trans, "history", item.id, recursive=True, purge=False)
else:
self.hda_manager.delete(item, flush=self.flush)
# In the edge case where all selected items are already deleted we need to force an update
# otherwise the history will wait indefinitely for the items to be deleted
item.update()

def _undelete(self, item: HistoryItemModel):
if getattr(item, "purged", False):
Expand Down

0 comments on commit 62ee88d

Please sign in to comment.