[24.0] Prevent inactive users from running workflows

Only in the case if `config.user_activation_on = True`
Fixes galaxyproject#18147

lib/galaxy/managers/context.py

@@ -256,7 +256,7 @@ def user_can_do_run_as(self) -> bool:
 
     @property
     def user_is_active(self) -> bool:
-        return not self.app.config.user_activation_on or self.user is None or self.user.active
+        return not self.app.config.user_activation_on or (self.user is not None and self.user.active)
 
     def check_user_activation(self):
         """If user activation is enabled and the user is not activated throw an exception."""

lib/galaxy/webapps/galaxy/services/workflows.py

@@ -124,6 +124,7 @@ def invoke_workflow(
         workflow_id,
         payload: InvokeWorkflowPayload,
     ) -> Union[WorkflowInvocationResponse, List[WorkflowInvocationResponse]]:
+        trans.check_user_activation()
         # Get workflow + accessibility check.
         by_stored_id = not payload.instance
         stored_workflow = self._workflows_manager.get_stored_accessible_workflow(trans, workflow_id, by_stored_id)