Skip to content

Commit

Permalink
fix published history collections are empty on expand
Browse files Browse the repository at this point in the history
Only check ownership in `__get_history_collection_instance` if:
`collection_instance.history.published` = False
  • Loading branch information
ahmedhamidawan committed Feb 8, 2024
1 parent 39bfc6a commit 1e8e885
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/galaxy/managers/collections.py
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,7 @@ def __get_history_collection_instance(
raise RequestParameterInvalidException("History dataset collection association not found")
# TODO: that sure looks like a bug, we can't check ownership using the history of the object we're checking ownership for ...
history = getattr(trans, "history", collection_instance.history)
if check_ownership:
if check_ownership and collection_instance.history.published is False:
self.history_manager.error_unless_owner(collection_instance.history, trans.user, current_history=history)
if check_accessible:
self.history_manager.error_unless_accessible(
Expand Down

0 comments on commit 1e8e885

Please sign in to comment.