Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update serialization for DestinationDefinitionRead object #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wkargul
Copy link
Contributor

@wkargul wkargul commented Oct 24, 2023

Update Serialization for DestinationDefinitionRead Object

Summary

This PR addresses serialization issues in the DestinationDefinitionRead object. The serialized JSON response was missing the custom field and the release_date was being deserialized incorrectly as a String instead of Vec<u16>.

Changes

  • Added missing custom field to serialized output
  • Updated the deserialization logic for release_date to use Vec<u16> instead of String

Example Serialized Response

{
  "destinationDefinitionId": "65de8962-48c9-11ee-be56-0242ac120002",
  "name": "Milvus",
  "dockerRepository": "airbyte/destination-milvus",
  "dockerImageTag": "0.0.1",
  "documentationUrl": "https://docs.airbyte.com/integrations/destinations/milvus",
  "icon": "<svg...></svg>",
  "protocolVersion": "0.2.0",
  "custom": false,
  "supportLevel": "community",
  "releaseStage": "alpha",
  "releaseDate": [2023, 8, 15],
  "supportsDbt": false,
  "normalizationConfig": {
    "supported": false
  }
}

Next Steps

After merging this PR, a new version of the library should be built and published to crates.io.

Please review and if all looks good, proceed with merging.

@wkargul
Copy link
Contributor Author

wkargul commented Oct 24, 2023

Hi @omid, please take a look on that :)

@omid
Copy link
Member

omid commented Oct 26, 2023

Please use the just file we have to do these replacements.
Then it'll be easier to do so when there is a new version.

@omid
Copy link
Member

omid commented Oct 26, 2023

Please also link to the code in airbyte with these specs, for custom and release_date 🙏🏼

@wkargul
Copy link
Contributor Author

wkargul commented Oct 31, 2023

Sure thing! I'll tweak it as soon as I can find a moment this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants