updating workflows

agracio · Oct 28, 2024 · ba3c8d3 · ba3c8d3
1 parent 0b6934b
commit ba3c8d3
Showing 1 changed file with 21 additions and 12 deletions.
diff --git a/.github/workflows/build-all.yml b/.github/workflows/build-all.yml
@@ -11,9 +11,6 @@ env:
 jobs:
   build:
     runs-on: ${{ matrix.os }}
-    outputs:
-      # test-version: ${{ steps.electron-test-version.outputs.test-version }}
-      matrix: ${{ steps.electron-test-versions.outputs.matrix }}
     strategy:
       # fail-fast: false
       matrix:
@@ -26,12 +23,7 @@ jobs:
 
       - name: Checkout code
         uses: actions/checkout@v4
-
-      - name: Resolve Electron versions from major
-        shell: bash
-        id: electron-test-versions
-        run: echo "matrix={\"include\":[{\"electron\":\"29.4.6\", \"os\":\"windows-2022\"},{\"electron\":\"30.5.1\", \"os\":\"windows-2022\"},{\"electron\":\"31.7.2\", \"os\":\"windows-2022\"},{\"electron\":\"32.2.2\", \"os\":\"windows-2022\"},{\"electron\":\"33.0.2\", \"os\":\"windows-2022\"}]}" >> $GITHUB_OUTPUT
-
+
       # - name: Setup env
       #   uses: ./.github/actions/setup-env
       #   with:
@@ -76,11 +68,28 @@ jobs:
       #     path: |
       #       release
 
-  test:
-    strategy:
-      matrix: ${{ fromJSON(needs.build.outputs.matrix) }}
+  electron-versions:
     runs-on: ${{ matrix.os }}
+    outputs:
+      test-versions: ${{ steps.electron-test-versions.outputs.test-versions }}
+    strategy:
+      # fail-fast: false
+      matrix:
+        os: [windows-2022]
     needs: build
+    steps:
+      - name: Electron versions
+        shell: bash
+        id: electron-test-versions
+        run: echo "test-versions={\"include\":[{\"electron\":\"29.4.6\"},{\"electron\":\"30.5.1\"},{\"electron\":\"31.7.2\"},{\"electron\":\"32.2.2\"},{\"electron\":\"33.0.2\"}]}" >> $GITHUB_OUTPUT
+
+  test:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix: 
+        os: [windows-2022]
+        electron: ${{ fromJSON(needs.electron-versions.outputs.test-versions) }}
+    needs: electron-versions
       # fail-fast: false
 
     name: test ${{ matrix.os }}-v${{ matrix.electron }}