Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the error message shown for AG0018: #155

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improve the error message shown for AG0018: #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
46fe8e4
Improve error message
szaboopeeter Feb 10, 2021
9fcfd86
Improve comment to match rule name
szaboopeeter Feb 10, 2021
cf928e7
Match copyright note with filename
szaboopeeter Feb 10, 2021
5f80f52
Update src/Agoda.Analyzers/AgodaCustom/CustomRulesResources.resx
szaboopeeter Feb 10, 2021
4daad90
Merge branch 'master' into fix-issue-149
szaboopeeter Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Agoda.Analyzers/AgodaCustom/AG0018PermitOnlyCertainPubliclyExposedEnumerables.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// <copyright file="AG0018EnsureThatPubliclyExposedIEnumerableTypes.cs" company="Agoda Company Co., Ltd.">
// <copyright file="AG0018PermitOnlyCertainPubliclyExposedEnumerables.cs" company="Agoda Company Co., Ltd.">
// AGODA ® is a registered trademark of AGIP LLC, used under license by Agoda Company Co., Ltd.. Agoda is part of Priceline (NASDAQ:PCLN)
// </copyright>
using System.Collections.Immutable;
Expand Down
2 changes: 1 addition & 1 deletion src/Agoda.Analyzers/AgodaCustom/CustomRulesResources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/Agoda.Analyzers/AgodaCustom/CustomRulesResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@
<value>Prevent use of dynamic</value>
</data>
<data name="AG0018Title" xml:space="preserve">
<value>Ensure that publicly exposed IEnumerable types</value>
<value>Strong return type, we recommend using interfaces over the concrete implementations. Publicly exposed enumerable types must be on our whitelist. e.g. IList, IEnum, etc. </value>
</data>
<data name="AG0026Title" xml:space="preserve">
<value>Use only CSS Selectors to find elements in Selenium tests</value>
Expand Down Expand Up @@ -248,4 +248,4 @@ One exception is logging, where it can be useful to see the exact DC / cluster /
<data name="AG0038Title" xml:space="preserve">
<value>Do not use #region directives</value>
</data>
</root>
</root>