-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE-356 + Added log retrieval command #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed this build error relating to some linting errors:
102:7 error Unused eslint-disable directive (no problems were reported from 'functional/no-return-void')
104:9 error Unused eslint-disable directive (no problems were reported from 'functional/no-let')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Thanks @desimpson. I've addressed your comments - this it ready for re-review. As an aside, we are switching to https://conventionalcomments.org/ so that we have a shared understanding about what is required (e.g. is something a blocking issue or a suggestion) to complete the review. |
Thanks, I'll use these labels in future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Command line options:
Same output in table mode: