Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE-356 + Added log retrieval command #48

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Conversation

dspasojevic
Copy link
Contributor

@dspasojevic dspasojevic commented Dec 5, 2023

Command line options:

Retrieves logs from okta

Okta connection settings:
      --client-id, --cid                   Okta client ID    [string] [required]
      --private-key, --pk                  Okta private key as string form of
                                           JSON              [string] [required]
      --organisation-url, --org-url, --ou  Okta URL for Organisation  [required]

Options:
      --version        Show version number                             [boolean]
      --help           Show help                                       [boolean]
  -o, --output-format  The format to output the logs in.
                          [string] [choices: "json", "table"] [default: "table"]
  -l, --limit          The number of logs to retrieve.    [number] [default: 10]
  -q, --query          The query by which the logs will be filtered (e.g. OIDC).
                                                                        [string]
  -f, --filter         The filter by which the logs will be filtered (e.g.
                       eventType eq "user.session.start").              [string]
      --since          The start date of the logs to retrieve.          [string]
      --until          The end date of the logs to retrieve.            [string]

Same output in table mode:

 ID                                    Published                 Severity  Type                Who    Message
 649c367a-9306-11ee-906b-9f37ae57e05c  2023-12-05T00:36:56.211Z  WARN      user.session.start  Dan S  User login to Okta
 c21c865c-9306-11ee-82fb-9b4e2ab3682d  2023-12-05T00:39:33.080Z  WARN      user.session.start  Dan S  User login to Okta

Copy link
Contributor

@desimpson desimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this build error relating to some linting errors:

   102:7  error  Unused eslint-disable directive (no problems were reported from 'functional/no-return-void')
  104:9  error  Unused eslint-disable directive (no problems were reported from 'functional/no-let')

src/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@desimpson desimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@dspasojevic
Copy link
Contributor Author

Thanks @desimpson. I've addressed your comments - this it ready for re-review.

As an aside, we are switching to https://conventionalcomments.org/ so that we have a shared understanding about what is required (e.g. is something a blocking issue or a suggestion) to complete the review.

@desimpson
Copy link
Contributor

Thanks @desimpson. I've addressed your comments - this it ready for re-review.

As an aside, we are switching to https://conventionalcomments.org/ so that we have a shared understanding about what is required (e.g. is something a blocking issue or a suggestion) to complete the review.

Thanks, I'll use these labels in future.

Copy link
Contributor

@desimpson desimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dspasojevic dspasojevic merged commit 943d52c into main Dec 5, 2023
1 check passed
@dspasojevic dspasojevic deleted the feature/IE-365-logs branch December 5, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants