Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

29 add toast component that instructs user to allow location services #46

Conversation

coherency1
Copy link
Contributor

Added simple Toast Component for Location Services use and other use cases.

  • Implemented Toast Component

  • Implemented Location Services Toast in App.jsx

  • No functionality for useState, will have to be implemented separately in components that utilize Toast

  • depending on show state, Toast component will either show Toast component, or display nothing

  • self containing functionality will have to be implemented later if needed

Component as shown below:

Screen.Recording.2023-03-22.at.2.28.17.AM.mov

@coherency1 coherency1 linked an issue Mar 22, 2023 that may be closed by this pull request
@coherency1 coherency1 self-assigned this Mar 22, 2023
@coherency1 coherency1 added the task A part of a user story that needs to be completed to finish the story label Mar 22, 2023
@coherency1 coherency1 added this to the Sprint 1 milestone Mar 22, 2023
@coherency1 coherency1 requested a review from 163dgm March 22, 2023 06:33
@@ -0,0 +1,9 @@
.toast {
background-color: --info;
padding-top: 5rem;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

padding for TopNav

.toast {
background-color: --info;
padding-top: 5rem;
z-index: 1000;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes it so Toast always shows at the front

@163dgm 163dgm requested a review from szcharlesji March 22, 2023 06:34
Copy link
Contributor

@163dgm 163dgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job

@shl622 shl622 merged commit 798e9b4 into master Mar 22, 2023
@coherency1 coherency1 deleted the 29-add-toast-component-that-instructs-user-to-allow-location-services branch April 2, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task A part of a user story that needs to be completed to finish the story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Toast component that instructs user to allow location services
3 participants