Update fork #2
Open
Update fork #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove redundant []byte to string conversion
Remove unnecessary blank (_) identifier from redisx/muxConn.Close
Enable golangci-lint checking in travis and fix errors identified by it. This mainly involves removing dead code and improving error checking such as: * activeConn.Close now returns any error from operations it performs instead of always returning nil.
Update godoc links to point to pkg.go.dev
Add config for clog which is used for generating release notes from our conventional commits. For details on the tool see: https://github.com/clog-tool/clog-cli
Fix compatibility of DialURL with respect for single component user-info records. This enables URLs such as redis://mypass@localhost/1 as supported by redis-cli to be used.
Add DialURLContext so that we consumers have control over cancelation and timeout Convert DialURL to call DialURLContext() and update docs to ensure consumers are aware of the new method, which should be preferred to ensure requests can't hang forever.
Add support for context during the Do cycle of a request. This is supported by DoContext and ReceiveContext to control the command life by both context and read timeout. Co-authored-by: Mikhail Mazurskiy <[email protected]> Co-authored-by: Lilith Games <[email protected]>
Fix DoContext call to DoWithTimeout passing args as variadic. Fixes #575
Upgrade testify to v1.7.0 eliminate security warning
Retract unpublished versions from go tooling. Bump go version to 1.16 required for retract statement. Fixes #585
Surface the underlying error when processing results for slice and map helpers so that the user can see the real cause and not a type mismatch error. Also: * Formatting changes to improve error case separation. * Leverage %w in reply errors. Fixes: #579
The actual string is "i/o timeout", but it's more clear to test error identity in the way documented for net.Conn. Fixes: #600
Add a wrapper that goes through the standard receiveInternal processing to match the API of the existing PubSubConn Receive methods. Fixes: #592
Add a Float64Map helper which can be used to convert a HGETALL responses to a map[string]float64.
Add a github action which runs go test so we can ensure that tests are passing before we merge changes.
Refactor the reply <type>Map helpers to reduce the code duplication in the body of those functions by creating a mapHelper along the same lines as the existing sliceHelper.
Update golangci-lint to a version compatible with golang 1.18.
Fix incorrect offset in error message for SlowLog conversion.
Update DialContext() to use the new DoContext() methods (added in v1.8.6) when configuring auth/clientName/db during connection creation. This prevents DialContex() from blocking for a long time if the redis server is unresponsive.
Remove go1.7 support which hasn't been maintained for a long time now.
Correct the error check in the Do method so it's more idiomatic.
Fix panic using ArgsFlat or ScanStruct on structs with nil Anonymous field pointers. Catch the anonymous struct recursion and prevent it. In the case of ScanStruct an error will be returned, in the case of ArgsFlat it will panic with a nice error.
Add support for LATENCY LATEST, LATEST HISTORY command parsing.
Ensure that goroutines started by tests are cleaned up on termination. Also: * make TestLatencyHistories compatible with -count=X. * Update to the supported versions of go 1.19 and 1.20. * Update golangci-lint to v1.15.2 Fixes #641
Update testify to eliminate security issue in dependent package gopkg.in/yaml.v3. Fixes #652
Update GitHub actions to use the latest versions and add go mod tidy check. This bumps go version for tests to 1.20 and 1.21 the currently supported versions. Update checks to validate against Redis 7.2 and 7.0, removing 5.0 and 4.0 which may still work but haven't been updated since 2020. Fix pubsub test instability due to unsubscribe notifications ordering not being guaranteed. Fix latency tests on Redis 7 due to DEBUG being disabled by default.
Run the Redis test server with --enable-debug-command local on Redis >= 7.0 which disables MODULE and DEBUG commands by default for better security. Without this, some unit tests fail on later Redis versions.
Remove debug check now we run the test server with debug enabled if needed.
Add TestOnBorrowContext to the Pool struct for checking the health of the idle connection with a given context.
Add goreleaser to automate the generation of release notes and bump the versions of github actions golang go the latest versions.
Remove deprecated goreleaser option --rm-dist and use --clean instead to prevent deprecation warning.
Retract v1.8.10 which was tagged incorrectly for a feature release and only available for a few minutes. v1.9.0 is identical.
Due to our test dependency requiring 1.17 minimum and the 1.16 being well out of support, currently only 1.21 and 1.22 are support releases, bump our required go version to 1.16. Fixes #665
Move checkout before go-setup so caching works.
Signed-off-by: rustfix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.