Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/display rich text reaction selector #471

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

wwrk22
Copy link
Contributor

@wwrk22 wwrk22 commented Jan 25, 2024

What's the change?

An emoji selector that creates rich text reactions has been added.
Created reactions are not yet displayed but the selector does work as intended.

Demo / Screenshots

Visit a standup meeting checkin page
e.g. http://localhost:3000/standup_meeting_groups/1/standup_meetings?date=01-08-2024

Click the smiley button underneath any rich text box to open the emoji selector, then click an emoji to create the reaction.
Screenshot 2024-01-25 at 5 27 23 PM
Screenshot 2024-01-25 at 5 27 29 PM

Check for the creation of a RichTextReaction in the Rails console. In this example, we created a reaction for yesterday_work_description of the StandupMeeting object.
Screenshot 2024-01-29 at 11 03 49 AM
Screenshot 2024-01-29 at 11 05 04 AM

Issue ticket number and link

#212

Checklist before requesting a review

Please delete items that are not relevant.

  • Did you add appropriate automated tests?
  • Have you thought of misfiring code? e.g. too many loops, n+1, or how to handle nils?
  • Related to readability and consistency: Did you add comments and/or documentation? (README, Notion, etc.)
  • Did you leave helpful inline PR comments for the reviewer(s)?
  • Did you include instructions for how to test in the ticket?
  • Did you add any relevant tags and decide if this PR is a Draft vs. Ready for Review?
  • Do you have a plan for how this change should be rolled back? (e.g., how do you deal with a migration rollback? Is your feature released behind a feature flag?)

@wwrk22 wwrk22 added solo This feature can be done without pairing with someone javascript Pull requests that update Javascript code labels Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06c9b49) 99.26% compared to head (88a21c1) 99.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
- Coverage   99.26%   99.26%   -0.01%     
==========================================
  Files         219      221       +2     
  Lines        3393     3387       -6     
==========================================
- Hits         3368     3362       -6     
  Misses         25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jp524
Copy link
Contributor

jp524 commented Jan 27, 2024

In the PR description Demo/Screenshots it would be good to have actual screenshots or a video recording of the feature working.

Copy link
Contributor Author

@wwrk22 wwrk22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jp524 @GALTdea
Comments were addressed. Let me know if there is more to address.
Thank you!

app/javascript/src/emoji_selector.js Outdated Show resolved Hide resolved
app/views/standup_meetings/_update.html.erb Outdated Show resolved Hide resolved
@wwrk22 wwrk22 added the ruby Pull requests that update Ruby code label Jan 29, 2024
Copy link
Contributor

@jp524 jp524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code ruby Pull requests that update Ruby code solo This feature can be done without pairing with someone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants