-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/display rich text reaction selector #471
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
==========================================
- Coverage 99.26% 99.26% -0.01%
==========================================
Files 219 221 +2
Lines 3393 3387 -6
==========================================
- Hits 3368 3362 -6
Misses 25 25 ☔ View full report in Codecov by Sentry. |
In the PR description Demo/Screenshots it would be good to have actual screenshots or a video recording of the feature working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the change?
An emoji selector that creates rich text reactions has been added.
Created reactions are not yet displayed but the selector does work as intended.
Demo / Screenshots
Visit a standup meeting checkin page
e.g. http://localhost:3000/standup_meeting_groups/1/standup_meetings?date=01-08-2024
Click the smiley button underneath any rich text box to open the emoji selector, then click an emoji to create the reaction.
Check for the creation of a RichTextReaction in the Rails console. In this example, we created a reaction for
yesterday_work_description
of theStandupMeeting
object.Issue ticket number and link
#212
Checklist before requesting a review
Please delete items that are not relevant.