-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add rich text reaction model #451
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
==========================================
+ Coverage 98.94% 98.97% +0.02%
==========================================
Files 209 216 +7
Lines 3231 3321 +90
==========================================
+ Hits 3197 3287 +90
Misses 34 34 ☔ View full report in Codecov by Sentry. |
64e142d
to
8b84d66
Compare
In the Demo / Screenshots section of the PR, last line should read |
Fixed |
0378337
to
f7e443a
Compare
- Removed test from meeting_update_component_spec.rb to add in a new branch.
…r code readability
- Moved rescue into #destroy since it's the only action that requires the logic.
aa26943
to
1388b6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one reminder of something to fix in here. The other stuff looks really good though.
# be any persisted ActiveRecord model record. By default, a User record is | ||
# used. | ||
transient do | ||
rich_text_owner { user } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoshDevHub
Some ActiveRecord model object has to be given for creating ActionText::RichText.
I decided the User model is probably the safest to use since it most likely won’t be going away or changed to a different name.
@@ -2,6 +2,8 @@ | |||
|
|||
RSpec.describe 'FactoryBot' do | |||
FactoryBot.factories.each do |factory| | |||
next if factory.name == :action_text_rich_text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoshDevHub
I think unless we can somehow have a fake ActiveRecord model with a fake database table, it’s best to skip linting the ActionText::RichText factory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright cool. Looks like you have to fix some merge conflicts and it'll be good to go
@JoshDevHub |
What's the change?
Added a model that stores emojis for reacting to standup meeting updates. The backend implementation was done on this branch.
What key workflows are impacted?
Users can create
RichTextReaction
records via the console to emulate reacting to standup meeting updates.Highlights / Surprises / Risks / Cleanup
The frontend implementation that includes the UI to allow users to react is still required.
Demo / Screenshots
Create reactons via the Rails console.
Issue ticket number and link
#212
This PR does not completely resolve the issue.
Checklist before requesting a review
Please delete items that are not relevant.