-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standup comments 1 #446
base: main
Are you sure you want to change the base?
Standup comments 1 #446
Conversation
…methods to allow it to service requests from the different sections
…le to utilize standup_meeting.id in test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
+ Coverage 99.26% 99.28% +0.02%
==========================================
Files 219 231 +12
Lines 3393 3505 +112
==========================================
+ Hits 3368 3480 +112
Misses 25 25 ☔ View full report in Codecov by Sentry. |
@@ -0,0 +1,7 @@ | |||
class StandupMeetings::SectionsController < ApplicationController |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This controller (along with its view) creates a dynamic view corresponding to the appropriate question/section in the standup meeting groups. e.g:
when params:
http://localhost:3000/standup_meetings/597/sections?section=yesterday_work_description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks and feels great to use. Huge props @GALTdea 🙌
Just have a few comments / requested changes. Let me know if you have any questions.
Also be sure to merge main and fix the conflicts.
spec/views/standup_meeting_comments/edit.html.tailwindcss_spec.rb
Outdated
Show resolved
Hide resolved
|
||
def allowed_section?(secion_name) | ||
ALLOWED_SECTIONS.include?(secion_name) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🙌
Let me know when you want me to review again @GALTdea |
Thank you, @JoshDevHub! I need to fix a couple of failing tests from my latest commits, I'll let you know when I do! |
What's the change?
What key workflows are impacted?
Allows users to interact with other users by leaving comments on their standup meeting updates
Highlights / Surprises / Risks / Cleanup
To be fully usable, I believe I should use Turbo for comments, especially to enable users to edit their comments. but this should be done in a different PR. I'll open one with those changes as soon as this one gets accepted.
Demo / Screenshots
Screen.Recording.2023-12-02.at.3.57.23.PM.mov
Issue ticket number and link
#418
Checklist before requesting a review
Please delete items that are not relevant.