Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add migration to replace indexes with new unique ons #435

Merged

Conversation

wwrk22
Copy link
Contributor

@wwrk22 wwrk22 commented Nov 16, 2023

What's the change?

Migration to replace StandupMeetingGroupUser indexes with new unique ones.

What key workflows are impacted?

N/A

Highlights / Surprises / Risks / Cleanup

N/A

Demo / Screenshots

N/A

Issue ticket number and link

#251

Checklist before requesting a review

  • Did you consider risks around security, performance, etc.?
  • Related to readability and consistency: Did you add comments and/or documentation? (README, Notion, etc.)
  • Did you leave helpful inline PR comments for the reviewer(s)?
  • Did you include instructions for how to test in the ticket?
  • Did you add any relevant tags and decide if this PR is a Draft vs. Ready for Review?
  • Do you have a plan for how this change should be rolled back? (e.g., how do you deal with a migration rollback? Is your feature released behind a feature flag?)

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0568c7) 98.93% compared to head (9d2386e) 98.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   98.93%   98.94%           
=======================================
  Files         214      215    +1     
  Lines        3207     3221   +14     
=======================================
+ Hits         3173     3187   +14     
  Misses         34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@toyhammered toyhammered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. You generally point this towards your other branch that is required to go first so this doesn't accidentally get merged in before.

@wwrk22
Copy link
Contributor Author

wwrk22 commented Nov 17, 2023

This looks good. You generally point this towards your other branch that is required to go first so this doesn't accidentally get merged in before.

Aha, that makes sense.

@wwrk22 wwrk22 force-pushed the feature/replace-smg-user-indexes-with-new-unique-ones branch from ba108d9 to 4ca65bc Compare November 17, 2023 16:46
@wwrk22
Copy link
Contributor Author

wwrk22 commented Nov 17, 2023

@toyhammered
Made a couple of commits to update the model spec.

@wwrk22 wwrk22 linked an issue Nov 18, 2023 that may be closed by this pull request
@toyhammered toyhammered merged commit 9eb48ba into main Nov 18, 2023
3 checks passed
@toyhammered toyhammered deleted the feature/replace-smg-user-indexes-with-new-unique-ones branch November 18, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Members can join the same group multiple times
2 participants