Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bootstrap-social with self-written CSS #496

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Conversation

FestplattenSchnitzel
Copy link
Member

No description provided.

Copy link
Collaborator

@lukasjuhrich lukasjuhrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result looks great, but I have the feeling that you have included way more CSS properties than necessary; most don't seem to be really doing anything.

sipa/static/css/agdsn-bootstrap-social.css Outdated Show resolved Hide resolved
sipa/static/css/agdsn-bootstrap-social.css Show resolved Hide resolved
sipa/static/css/agdsn-bootstrap-social.css Outdated Show resolved Hide resolved
sipa/static/css/agdsn-bootstrap-social.css Outdated Show resolved Hide resolved
sipa/static/css/agdsn-bootstrap-social.css Outdated Show resolved Hide resolved
sipa/static/css/agdsn-bootstrap-social.css Outdated Show resolved Hide resolved
sipa/static/css/agdsn-bootstrap-social.css Outdated Show resolved Hide resolved
* Replace Facebook with Instagram
* GitHub: Link organisation instead of this project
@lukasjuhrich lukasjuhrich merged commit e11a8d8 into develop Sep 17, 2024
7 checks passed
@FestplattenSchnitzel FestplattenSchnitzel deleted the social-icons branch September 17, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants