Upgrade to Bootstrap 5 #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to remove lots of unnecessary CSS.
The bootstrap-toc project is rather unmainted, Tocbot is the alternative recommended by the authors. Also see afeld/bootstrap-toc#74
This - fixes the label classes - uses more subtle coloring (text-secondary for the metadata, desaturated colors for the labels to not make them the primary focus) - groups everything in an `article` tag for improved semantics - adds a border to the left with the color of the tag with the highest severity
This resolves undefined behavior, where it previously depended on the ordering of the components whether the returned status was `maintenance` or `performanceIssues`.
this means we will be deploying testing config to production, but it wasn't worth hard-coding a switch for this file in the dokcer build setup. This file can conveniently be edited to check all the relevant states of the statuspage widget.
Putting script tags at the end of the HTML element was done to avoid blocking further HTML parsing and DOM loading – whenever a script tag is encountered, a browser has to parse and interpret the JS inside of it. A disadvantage of this strategy is that the scripts will be fetched only after parsing the HTML Using `defer` while putting the scripts in the `head` solves both of these problems.
These are all icons used in pages today. To migrate, replace the `glyphicon: …` metadata entry by `icon: …`.
The templates have been given meaningful names, and the page template is now no longer abused to render a news article.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.