Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

funExt is an equivalence. #1070

Merged
merged 12 commits into from
Nov 2, 2023
Merged

funExt is an equivalence. #1070

merged 12 commits into from
Nov 2, 2023

Conversation

smimram
Copy link
Contributor

@smimram smimram commented Oct 24, 2023

The fact that funExt is an equivalence (this is already proved for pointed types, but not for non-pointed ones).

@mzeuner
Copy link
Contributor

mzeuner commented Oct 24, 2023

If I'm not mistaken, this is already in the library, albeit in a somewhat hidden place:
https://github.com/agda/cubical/blob/master/Cubical/Functions/FunExtEquiv.agda#L25

Maybe it's worth refactoring things a bit though, or move this file to Foundations, so it can be found more easily...

@mortberg
Copy link
Collaborator

If I'm not mistaken, this is already in the library, albeit in a somewhat hidden place: https://github.com/agda/cubical/blob/master/Cubical/Functions/FunExtEquiv.agda#L25

Maybe it's worth refactoring things a bit though, or move this file to Foundations, so it can be found more easily...

Indeed, this is proved elsewhere. Maybe a comment with a pointer to that proof in Foundations.Equiv would be sufficient? Or we move the unary case and have a comment about higher arity versions being in the Functions package?

@smimram
Copy link
Contributor Author

smimram commented Oct 24, 2023

Thanks and sorry about not finding this out! I let you decide if you want to do something about this or simply close the PR.

@mortberg
Copy link
Collaborator

mortberg commented Nov 2, 2023

If I'm not mistaken, this is already in the library, albeit in a somewhat hidden place: https://github.com/agda/cubical/blob/master/Cubical/Functions/FunExtEquiv.agda#L25
Maybe it's worth refactoring things a bit though, or move this file to Foundations, so it can be found more easily...

Indeed, this is proved elsewhere. Maybe a comment with a pointer to that proof in Foundations.Equiv would be sufficient? Or we move the unary case and have a comment about higher arity versions being in the Functions package?

I implemented the comment with a pointer solution now in this PR. Will merge as soon as the CI is finished

@mortberg mortberg merged commit e78ac78 into agda:master Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants