Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all agda files #1058

Merged
merged 7 commits into from
Feb 2, 2024
Merged

Check all agda files #1058

merged 7 commits into from
Feb 2, 2024

Conversation

felixwellen
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@mortberg mortberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files should be kept IMO and some I don't know if we should throw out or not

Cubical/Experiments/IntegerMatrix.agda Outdated Show resolved Hide resolved
Cubical/Experiments/List.agda Outdated Show resolved Hide resolved
Cubical/Experiments/HInt.agda Show resolved Hide resolved
Cubical/Experiments/CountingFiniteStructure.agda Outdated Show resolved Hide resolved
Cubical/Experiments/Combinatorics.agda Outdated Show resolved Hide resolved
Cubical/Experiments/LocalisationDefs.agda Show resolved Hide resolved
Cubical/Experiments/CohomologyGroups.agda Show resolved Hide resolved
Cubical/Experiments/ZariskiLatticeBasicOpens.agda Outdated Show resolved Hide resolved
@felixwellen
Copy link
Collaborator Author

Maybe I should add: I don't actually if all of them don't check. After a couple of them failed, I just removed everything not in Everything.agda

@felixwellen felixwellen marked this pull request as draft September 18, 2023 09:17
@mortberg
Copy link
Collaborator

Maybe I should add: I don't actually if all of them don't check. After a couple of them failed, I just removed everything not in Everything.agda

Ok, I think it would be better to check which check and then add them to Everything. Then we can decide whether we fix the broken ones or not

@mortberg
Copy link
Collaborator

Maybe I should add: I don't actually if all of them don't check. After a couple of them failed, I just removed everything not in Everything.agda

Ok, I think it would be better to check which check and then add them to Everything. Then we can decide whether we fix the broken ones or not

Ps: it would be good not to have a manually written Everything file. It's very easy to forget to add new files

@felixwellen
Copy link
Collaborator Author

Ps: it would be good not to have a manually written Everything file. It's very easy to forget to add new files

Yes, absolutely. We shouldn't have done that ;-)

@felixwellen
Copy link
Collaborator Author

Also note that we have more manually maintained Everything.agdas as the one in Experiments:

.PHONY : gen-everythings
gen-everythings:
	$(EVERYTHINGS) gen-except Core Foundations Codata Experiments

I guess the otheres might be more unlikely to lead to issues, since the stuff in those folders is likely to be used elsewhere. If there are files that don't check, I should have seen it by now.
I don't know why we are doing this though.

@mortberg
Copy link
Collaborator

Also note that we have more manually maintained Everything.agdas as the one in Experiments:

.PHONY : gen-everythings
gen-everythings:
	$(EVERYTHINGS) gen-except Core Foundations Codata Experiments

I guess the otheres might be more unlikely to lead to issues, since the stuff in those folders is likely to be used elsewhere. If there are files that don't check, I should have seen it by now. I don't know why we are doing this though.

I don't know either. Feel free to figure out which check and then we can decide what to do about those that don't, and eventually get rid of gen-except...

@felixwellen
Copy link
Collaborator Author

Some of the manual Everything.agda are about flags...

@felixwellen
Copy link
Collaborator Author

Core, Foundation, Codata all have Everything.agdas for some reason: They reexport a lot, or use some special flags, don't have a safe flag,...
So I'll leave that as it is and just switch the Experiments/Everything.agda to automatic.

@felixwellen felixwellen marked this pull request as ready for review January 25, 2024 23:09
@felixwellen felixwellen changed the title Remove experimental files that don't type check Actually check all agda files Jan 26, 2024
@felixwellen felixwellen changed the title Actually check all agda files Check all agda files Jan 26, 2024
Copy link
Collaborator

@mortberg mortberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if @aljungstrom responds by tomorrow, otherwise you can merge. It seems silly to keep completely commented files though...

@felixwellen
Copy link
Collaborator Author

There are still some out-commented parts of files, but I think the situation is still a lot better than before, so I'll merge.

@felixwellen
Copy link
Collaborator Author

(...after the rebase checks out)

@felixwellen felixwellen merged commit c6a96ee into master Feb 2, 2024
1 check passed
@felixwellen felixwellen deleted the fwellen/rm-non-checking branch February 2, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants