Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.6 for agda 2.6.4 #1050

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Conversation

felixwellen
Copy link
Collaborator

Just one fix from #1048

@felixwellen felixwellen force-pushed the fwellen/check-with-current-agda branch from 33ce421 to fc99ea4 Compare October 10, 2023 08:16
@felixwellen felixwellen changed the title Check with current agda 2.6.4 Release v0.6 for agda 2.6.4 Oct 10, 2023
@felixwellen
Copy link
Collaborator Author

If there is something to do nix-wise can someone do it?
(Ping @MatthiasHu @jpoiret )
I cannot check this on my machine:
image

@felixwellen
Copy link
Collaborator Author

If there is something to do nix-wise can someone do it? (Ping @MatthiasHu @jpoiret ) I cannot check this on my machine: image

Or @ncfavier ?

@ncfavier
Copy link
Member

Agda build runs out of memory.

@felixwellen
Copy link
Collaborator Author

If I get it right, the flake for agda is used to build agda, which means it is built with a lot of optimization. So it is no surprise it runs out of memory. Is there a way to prevent this? Can we use a build of agda?

@ncfavier
Copy link
Member

AFAICT we have three options:

  1. set up a Cachix cache for the agda organisation and push builds of released versions there, either manually or via CI
  2. wait for Agda 2.6.4 to land in nixpkgs and use that, since the build will be cached on cache.nixos.org (Update request: agda 2.6.3 → 2.6.4 NixOS/nixpkgs#259572)
  3. remove optimise-heavily using an overlay and see if that builds

@ncfavier
Copy link
Member

ncfavier commented Oct 10, 2023

In case we want to go with 1, I've created a Cachix cache (https://agda.cachix.org). Members of the agda GitHub organisation should have write access (if they log into Cachix via their GitHub account?).

@felixwellen
Copy link
Collaborator Author

Thanks!
But I actually tend somewhat towards deactivating the nix-workflow. It seems a bit like it is mostly testing if the flake (and the agda flake) still works on github's machines. Shouldn't it be enough if someone tests it locally, which you probably did today when you produced the flake.lock?
I'll of course wait a bit if someone solves the problem, but this is my default plan (which is not yet discussed with other maintainers).

@felixwellen
Copy link
Collaborator Author

Just to be clear: I am happy about the nix-workflow as long as it doesn't block the release. So if someone implements an easy solution (the "overlay" suggestion sounds like one) that's perfectly fine from my point of view.

@phijor
Copy link
Contributor

phijor commented Oct 12, 2023

I built 82aa301 locally with nix on the updated flake. I can confirm that it succeeds without errors/warnings.

In general I'm in favor of caching build artifacts via Cachix. Not only does it reduce build time, but people downstream would benefit from the caching, too.

AFAICT we have three options:

What about a fourth option: Provide two outputs in the flake:

  1. one depending on stable Agda (found in nixpkgs). This wouldn't have to build Agda from source and would break whenever changes depending on an unreleased Agda are introduced (which isn't necessarily bad)
  2. one depending on an unreleased version of agda, as it's done right now. One could tweak it to build a non-optimized Agda, if the point is to catch breaking changes. If the cache is shared across the entire organization it might not even be necessary to rebuild at all.

In any case, I'm willing to help out tweaking the nix workflow so that it doesn't block future releases.

@ncfavier
Copy link
Member

I'm on board with removing the Nix workflow.

@ncfavier
Copy link
Member

Note that 0.5 compiles with agda 2.6.4. Maybe that should be noted in the README.

@felixwellen felixwellen force-pushed the fwellen/check-with-current-agda branch from 82aa301 to bfc5756 Compare October 24, 2023 10:16
@felixwellen felixwellen force-pushed the fwellen/check-with-current-agda branch from bfc5756 to 05c4dc0 Compare October 24, 2023 10:22
@felixwellen
Copy link
Collaborator Author

I removed the ci-nix.yml, just because commenting out the whole file didn't work and I don't want to spend time on this.
I also added 2.6.4 as an additional agda-version you can use with v0.5

@mortberg
Copy link
Collaborator

Looks good to me! Thanks for preparing this

@felixwellen felixwellen marked this pull request as ready for review October 24, 2023 14:26
@felixwellen
Copy link
Collaborator Author

Ok - will do.

@felixwellen felixwellen merged commit eb6a33c into master Oct 24, 2023
1 check passed
LuuBluum pushed a commit to LuuBluum/cubical that referenced this pull request Oct 29, 2023
* update some call following agda's warning

* bump versions everywhere

* bump versions everywhere

* nix: flake update

* README: more working agda-versions

* deactivate ci-nix

* update release date

---------

Co-authored-by: Naïm Favier <[email protected]>
@felixwellen felixwellen deleted the fwellen/check-with-current-agda branch February 15, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants