Move Rationals around #1027
Merged
Move Rationals around #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, can I request a review here, say from @ecavallo ? |
|
Don't know if anyone is working right now (I am also on vacation). I am back next week and might have time for reviewing (don't know what yet). |
|
This seems reasonable to me. What do you think @felixwellen @ecavallo ? |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now they are in
Dataand structured more like the various integers. In particular,QuoQis now "the preferred version of the rationals in the library" – I picked it since it was the only one used in other places.This is intended to be part of #404 – if this gets accepted then the only remaining work there will be proving the equivalence of
HITQandQuoQ. I'm already working on that, the main hurdle being that they are defined using different integers, so I first want to prove that arithmetic operations on the integers are equal.