Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorical bits and pieces #1008

Merged
merged 11 commits into from
Aug 22, 2023
Merged

Categorical bits and pieces #1008

merged 11 commits into from
Aug 22, 2023

Conversation

jpoiret
Copy link
Contributor

@jpoiret jpoiret commented Jun 5, 2023

Hi,

While attempting a categorical formulation of #1007 that I abandoned in the end, I collected a lot of simple results and modifications.

Noteworthy changes are 2491f5f, a change to the definition of being an equivalence, which previously was not an hProp. I fixed all uses of it in the library to be compatible with the new definition. I also separated triangle identities from the definition of an adjunction in c55988c, so that I could more easily add adjoint equivalences in c9cb16b.

From what I can tell this is independent to #988, and shouldn't interfere with it.

LMKWYT

@felixwellen felixwellen marked this pull request as draft June 9, 2023 14:49
@jpoiret
Copy link
Contributor Author

jpoiret commented Jun 30, 2023

I just removed the stuff about subpresheaves and representable presheaves, as there's going to be something better with #988 anyways (I have to make time to send some changes to it).

@jpoiret jpoiret marked this pull request as ready for review June 30, 2023 15:05
@felixwellen
Copy link
Collaborator

Can you rebase?

Copy link
Collaborator

@felixwellen felixwellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
I commented only on one small detail and will merge anyway if you don't have the time to fix it.
One question though: Are there any candidates we should consider as a definition of isEquivalence, which are naturally a proposition?

Cubical/Categories/Adjoint.agda Outdated Show resolved Hide resolved
@jpoiret
Copy link
Contributor Author

jpoiret commented Aug 17, 2023

Just pushed with the comment removed + a stylistic change in AdjointEquivalence. wrt. isEquivalence, I don't know of a good representation of it. If C is univalent, then being an adjoint equivalence might be it, but that's not a general characterization.

@felixwellen
Copy link
Collaborator

Thanks! Maybe you can put what you know into a comment at isEquivalence, I guess it is natural to wonder about that when reading the definition.

@felixwellen
Copy link
Collaborator

With "what you know" I mean that we don't know a notion which works analogous to "isEquiv" for not necessarily univalent categories.

@felixwellen
Copy link
Collaborator

Thanks!
I'll merge.

@felixwellen felixwellen merged commit 5fe4366 into agda:master Aug 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants