-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Categorical bits and pieces #1008
Conversation
I just removed the stuff about subpresheaves and representable presheaves, as there's going to be something better with #988 anyways (I have to make time to send some changes to it). |
Can you rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I commented only on one small detail and will merge anyway if you don't have the time to fix it.
One question though: Are there any candidates we should consider as a definition of isEquivalence
, which are naturally a proposition?
745fd12
to
bb35d73
Compare
Just pushed with the comment removed + a stylistic change in |
Thanks! Maybe you can put what you know into a comment at |
With "what you know" I mean that we don't know a notion which works analogous to "isEquiv" for not necessarily univalent categories. |
This has the same computational behavior, except that you get more definitional equalities since functors don't have eta-expansion.
bb35d73
to
0227713
Compare
Thanks! |
Hi,
While attempting a categorical formulation of #1007 that I abandoned in the end, I collected a lot of simple results and modifications.
Noteworthy changes are 2491f5f, a change to the definition of being an equivalence, which previously was not an hProp. I fixed all uses of it in the library to be compatible with the new definition. I also separated triangle identities from the definition of an adjunction in c55988c, so that I could more easily add adjoint equivalences in c9cb16b.
From what I can tell this is independent to #988, and shouldn't interfere with it.
LMKWYT