Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all⊆concat #2513

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Add all⊆concat #2513

merged 2 commits into from
Dec 9, 2024

Conversation

jamesmckinna
Copy link
Contributor

Fixes #2509

NB. Tweaks the imports in order to have clean separation of Sublist._⊆_ and its properties from Subset._⊆_.

@jamesmckinna jamesmckinna added this to the v2.2 milestone Dec 8, 2024
MatthewDaggitt
MatthewDaggitt approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@MatthewDaggitt MatthewDaggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise all looks good!

src/Data/List/Relation/Unary/All/Properties.agda Outdated Show resolved Hide resolved
@MatthewDaggitt MatthewDaggitt added this pull request to the merge queue Dec 9, 2024
Merged via the queue into agda:master with commit 6633371 Dec 9, 2024
2 checks passed
@jamesmckinna jamesmckinna deleted the issue2509 branch December 11, 2024 08:15
This was referenced Dec 11, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewDaggitt MatthewDaggitt MatthewDaggitt approved these changes

Assignees
No one assigned
Labels
addition low-hanging-fruit refactoring
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.

suggested "concat members are sublists"
2 participants
@jamesmckinna @MatthewDaggitt