Make Cancellative be more consistent in whole library #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s be explicit, as per #1436.
…o match the definitions wrt implicits (but not use them because of NonZero)
|
Looks good so far, let us know when it's ready to be reviewed! |
|
@MatthewDaggitt the changes in the PR are incomplete because of the issues that I noted in the comments to #1436 . My feeling is that we might want to consider this PR as self-contained (once I write something for the CHANGELOG) and then discuss some more what might still need done for increased consistency (if anything). |
|
Sounds like a plan! |
|
Thanks hugely for the CHANGELOG. As far as I'm concerned, this PR is now ready to go. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work done for Issue #1436 . Making the PR now to get a CI run.