Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ fix #1354 ] Refactoring Permutation.Propositional #1761

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

gallais
Copy link
Member

@gallais gallais commented May 3, 2022

Still missing: CHANGELOG entries

@MatthewDaggitt
Copy link
Contributor

Closing as we've decided that its better to wait for typed pattern synonyms to finally make an appearance.

@jamesmckinna
Copy link
Contributor

jamesmckinna commented Mar 17, 2024

Suggest re-opening this, as I seem to have got it to work with the pattern synonyms... using some ideas from #2317 and #2321 towards further unification, if someone can help me unify the two Permutation.*.Properties modules along the lines considered in #2317 ... incoming revised/streamlined/refactored/rebased commits shortly.

UPDATED: as with that more recent PR, will convert to DRAFT for now until ready to review.

@jamesmckinna jamesmckinna reopened this Mar 17, 2024
@jamesmckinna jamesmckinna marked this pull request as draft March 17, 2024 15:45
Copy link
Contributor

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that one odd name (which seems to actually be something pre-existing), this is looking quite good.

@MatthewDaggitt MatthewDaggitt removed the status: won't-merge Decided against merging the PR in. label Mar 18, 2024
@jamesmckinna
Copy link
Contributor

jamesmckinna commented Mar 18, 2024

So far all the heavy lifting was done years ago by @gallais so props to him.

But I think that my recent work on #2317 hopefully points the way to getting the Properties unified as well. If that succeeds, then most of the guff in Propositional disappears entirely, and with it, all/most of the angst about qualified import of refl... I hope. Fingers crossed!

UPDATED Lots of refactoring work on #2317 ahead of bringing it to bear on this PR. But first see #2333 as a more manageable first part of a roadmap detailed there.

@jamesmckinna
Copy link
Contributor

Removing the milestone marker from this for the time being...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reimplement Permutation.Propositional in terms of Permutation.Setoid
4 participants