-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ fix #1354 ] Refactoring Permutation.Propositional #1761
base: master
Are you sure you want to change the base?
Conversation
Closing as we've decided that its better to wait for typed pattern synonyms to finally make an appearance. |
Suggest re-opening this, as I seem to have got it to work with the pattern synonyms... using some ideas from #2317 and #2321 towards further unification, if someone can help me unify the two UPDATED: as with that more recent PR, will convert to DRAFT for now until ready to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that one odd name (which seems to actually be something pre-existing), this is looking quite good.
So far all the heavy lifting was done years ago by @gallais so props to him. But I think that my recent work on #2317 hopefully points the way to getting the UPDATED Lots of refactoring work on #2317 ahead of bringing it to bear on this PR. But first see #2333 as a more manageable first part of a roadmap detailed there. |
Removing the milestone marker from this for the time being... |
Still missing: CHANGELOG entries