Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dockerfile #64

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Added dockerfile #64

merged 2 commits into from
Aug 4, 2023

Conversation

andrej-s
Copy link

Hello, thank you for this great project! I am using tempo inside a Docker container and thought you might be interested in adding this to your repo.

Anyways, thanks again, Agate.

Copy link
Owner

@agateblue agateblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! I have tested locally and it works great. I wanted to add a couple small changes before merging but unfortunately I don't have the permission to edit your branch.

Do you think you could add a .dockerignore file containing node_modules/ and the following section at the end of the README.md?

Deploying using Docker

If you want to deploy Tempo using Docker, you can use our Dockerfile:

docker build -t tempo .
docker run --rm -p 8097:80 tempo

The image includes an Nginx server and a compiled bundle of Tempo assets.


@andrej-s
Copy link
Author

andrej-s commented Aug 4, 2023

More than happy to do so, @agateblue - one question though: I am not sure adding node_modules to a dockerignore file, as there is no such folder on your repo, and when copying data to the final image, we only copy the build folder - the final image is as sleek as can be. Maybe I am misunderstanding. Just let me know if you'd like me to still add a dockerignore and I'll happily oblige.

@agateblue
Copy link
Owner

More than happy to do so, @agateblue - one question though: I am not sure adding node_modules to a dockerignore file, as there is no such folder on your repo, and when copying data to the final image, we only copy the build folder - the final image is as sleek as can be. Maybe I am misunderstanding. Just let me know if you'd like me to still add a dockerignore and I'll happily oblige.

Sorry, I should have given more context: in a local/dev environment where you try or work on Tempo with and without docker, node_modules exists and building the image can take a while because this folder is passed into the docker build context ;)

@andrej-s
Copy link
Author

andrej-s commented Aug 4, 2023

Perfect, makes sense! I followed both your suggestions.

Copy link
Owner

@agateblue agateblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks again for your help on this :)

@agateblue agateblue merged commit 6c2761c into agateblue:main Aug 4, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants