fix always fullscreen mode #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The window layout was always being set to FULLSCREEN mode to workaround a flickering status bar bug, but it did not respect the app preference and return to FORCE_NOT_FULLSCREEN when applicable. This had a side effect of breaking the adjustResize windowSoftInputMode setting, where the soft keyboard being shown would not resize the viewport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #115
The window layout was always being set to FULLSCREEN mode to workaround a flickering status bar bug, but it did not respect the app preference and return to FORCE_NOT_FULLSCREEN when applicable. This had a side effect of breaking the adjustResize windowSoftInputMode setting, where the soft keyboard being shown would not resize the viewport.