Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captain Agent PR part 2. #46

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Captain Agent PR part 2. #46

merged 6 commits into from
Nov 20, 2024

Conversation

LeoLjl
Copy link
Collaborator

@LeoLjl LeoLjl commented Nov 19, 2024

Part 2 of CaptainAgent PR. It implements the code specified in the blog post introduced in #27. The full context in #21.

Why are these changes needed?

Related issue number

Checks

@qingyun-wu
Copy link
Collaborator

Thanks @LeoLjl! Reviewing it. Could you fix the doc failure first?

@qingyun-wu qingyun-wu requested a review from sonichi November 20, 2024 02:49
@qingyun-wu
Copy link
Collaborator

Please fix docs failure

Copy link
Collaborator

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now! Thanks Jiale! I think we are ready to move on to Part 3.

@qingyun-wu
Copy link
Collaborator

Looks good to me now! Thanks Jiale! I think we are ready to move on to Part 3.

@skzhang1 In the meanwhile, could you make a PR to update the visualization or upload it here? Thank you!

@qingyun-wu qingyun-wu requested a review from sonichi November 20, 2024 20:23
@qingyun-wu qingyun-wu merged commit 6abff18 into main Nov 20, 2024
157 of 164 checks passed
davorrunje pushed a commit that referenced this pull request Dec 20, 2024
Remove duplicate entry from navigation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Roadmap Issue]: CaptainAgent
4 participants