Introduced Credentials into conftest and refactored tests #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AI_CONFIG_LIST in tests
davorrunje
changed the title
rjambrecic
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are currently manipulation the
OAI_CONFIG_LISTfile manually. This PR uses fixtures for constructingllm_configandconfig_listobject. Since they contain sensitive information, they are encapsulated into aCredentialsobject that overrides__repr__and__str__methods in such a way to redact API keys. All tests are refactored to use new way of handling secrets in tests.Why are these changes needed?
Related issue number
Closes #389
Checks